Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eduvpn-client: init at 3.1.0 #210180

Closed
wants to merge 2 commits into from
Closed

Conversation

kilianar
Copy link
Contributor

Description of changes

Add eduvpn, a Linux client and Python client API for eduVPN.

I tested the application with the vpn of my university and everything worked fine.

There was a previous attempt to get this into nixpkgs with #36122, but the pr was closed by the author (@leenaars).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1779

pkgs/development/python-modules/eduvpn-client/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eduvpn-client/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eduvpn-client/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eduvpn-client/default.nix Outdated Show resolved Hide resolved
@@ -2943,6 +2943,8 @@ self: super: with self; {
inherit (pkgs) edlib;
};

eduvpn-client = callPackage ../development/python-modules/eduvpn-client { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an end user program so it should not be in pythonPackages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some discussion about this in the previous pr: #36122 (comment). There is a python API, but I'm not sure if it's actually used by anyone as it's not well documented. Should I drop it from pythonPackages nevertheless?

Add eduvpn-client, a Linux client and Python client API for eduVPN.

https://github.com/eduvpn/python-eduvpn-client/releases/tag/3.1.0
@kilianar
Copy link
Contributor Author

kilianar commented Apr 5, 2023

I'm closing this pull request because a new version has been released that moved the core functionality into a Go library. Python bindings can be generated for this library, but the packaging process now requires more effort and differs substantially from the current state. Therefore, it should be addressed in a future pull request.

@kilianar kilianar closed this Apr 5, 2023
@kilianar kilianar deleted the eduvpn-init branch April 5, 2023 20:51
@jwijenbergh jwijenbergh mentioned this pull request Jan 5, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants