-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eduvpn-client: init at 3.1.0 #210180
eduvpn-client: init at 3.1.0 #210180
Conversation
03d86df
to
7525e77
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1779 |
@@ -2943,6 +2943,8 @@ self: super: with self; { | |||
inherit (pkgs) edlib; | |||
}; | |||
|
|||
eduvpn-client = callPackage ../development/python-modules/eduvpn-client { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an end user program so it should not be in pythonPackages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some discussion about this in the previous pr: #36122 (comment). There is a python API, but I'm not sure if it's actually used by anyone as it's not well documented. Should I drop it from pythonPackages nevertheless?
Add eduvpn-client, a Linux client and Python client API for eduVPN. https://github.com/eduvpn/python-eduvpn-client/releases/tag/3.1.0
I'm closing this pull request because a new version has been released that moved the core functionality into a Go library. Python bindings can be generated for this library, but the packaging process now requires more effort and differs substantially from the current state. Therefore, it should be addressed in a future pull request. |
Description of changes
Add eduvpn, a Linux client and Python client API for eduVPN.
I tested the application with the vpn of my university and everything worked fine.
There was a previous attempt to get this into nixpkgs with #36122, but the pr was closed by the author (@leenaars).
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes