ddev: init at 1.21.4 #210579
ddev: init at 1.21.4 #210579
Conversation
|
Hello, Since ddev rely on Docker, I believe you should add it as a dependency, or else it won't work at all. |
|
@drupol , that makes sense. I added both docker and docker-compose. |
|
@drupol , is there anything else I should do on this PR? Thanks in advance. |
|
Hi, I don't know since I never used Leave it open, someone else will most probably give some feedback at some point. |
|
built correctly on x86_64-linux, binary seems to be working although I never used ddev. |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "drud"; | ||
| repo = "ddev"; |
There was a problem hiding this comment.
| repo = "ddev"; | |
| repo = pname; |
@JulienMalka |
You probably want to do something like |
|
@JulienMalka, thanks. I force pushed those requested changes. Please let me know if there's anything else I can do. |
|
Anything more that I should do on this for merging? This is my first submission, so I don't know the process. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| , ddev }: | ||
|
|
||
| buildGoPackage rec { | ||
| pname = "ddev"; |
There was a problem hiding this comment.
Please use buildGoModule
ofborg
bot
added
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
| let | ||
| pname = "ddev"; | ||
| version = "1.21.6"; | ||
| in | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = pname; | ||
| version = version; | ||
| src = fetchFromGitHub { | ||
| owner = "ddev"; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| sha256 = "sha256-Wjg0Yxo/ulY6R6hhUMFvNZUSwpXENmAHU7GPbgdw7tw="; | ||
| }; |
There was a problem hiding this comment.
| let | |
| pname = "ddev"; | |
| version = "1.21.6"; | |
| in | |
| stdenv.mkDerivation { | |
| name = pname; | |
| version = version; | |
| src = fetchFromGitHub { | |
| owner = "ddev"; | |
| repo = pname; | |
| rev = "v${version}"; | |
| sha256 = "sha256-Wjg0Yxo/ulY6R6hhUMFvNZUSwpXENmAHU7GPbgdw7tw="; | |
| }; | |
| stdenv.mkDerivation rec { | |
| pname = "ddev"; | |
| version = "1.21.6"; | |
| src = fetchFromGitHub { | |
| owner = "ddev"; | |
| repo = "ddev"; | |
| rev = "v${version}"; | |
| sha256 = "sha256-Wjg0Yxo/ulY6R6hhUMFvNZUSwpXENmAHU7GPbgdw7tw="; | |
| }; | |
|
Please follow the contributing guide when naming your commits. |
| rev = "v${version}"; | ||
| sha256 = "sha256-Wjg0Yxo/ulY6R6hhUMFvNZUSwpXENmAHU7GPbgdw7tw="; | ||
| }; | ||
| buildInputs = [ bash curl git go ]; |
There was a problem hiding this comment.
Please patch that the build requires a git clone. We can replace the values returned by git with dummy values or version.
build flags: SHELL=/nix/store/zlf0f88vj30sc7567b80l52d19pbdmy2-bash-5.2-p15/bin/bash build
fatal: not a git repository (or any of the parent directories): .git
make: *** [Makefile:96: .gotmp/bin/darwin_arm64/mkcert] Error 6
Also please split the packages for cross compilation into nativeBuildInputs and buildInputs.
|
Sorry, I didn't mean to leave this PR open. I need to rework this. Attempting to use the upstream Makefile fails due to the Makefile downloading external files (binary for mkcert). Withdrawing PR. |
|
@jgonyea I rely on DDEV and it keeps me from switching to NixOS on the desktop. I'd be happy to test the functionality as soon as it is testable. Thanks for your contribution. |
|
@jgonyea I'm happy to help you get this going again. |
|
@rfay I created a buildable ddev package and put it on the NUR for the time being. I spoke to @jgonyea and the plan is for me to create a new RP from that soon. |
|
Nice! Is there a way to get notifications for that? How does it get updated (since we're at v1.22.1?) |
Use the configuration from the blog post and the package will update along with the system. In terms of it being up to date in the NUR, it seems I am responsible for now. I subscribe to ddev and will be pushing relatively timely updates. I believe you can subscribe to my repository directly to get updates on the package - this is where the NUR runner is pulling changes from. |
|
Sorry for the interruption but... why is |
I mentioned earlier that I intend to create a PR very soon. Still testing things ATM. |
|
Subscribed, thanks. |
One more thing, keep in mind the NUR runner is active once a day or so so you won't see changes right after I push an update to my repo. :/ |
|
I submitted #250017 which is a lightly edited version of what I have been using and maintaining personally since December 2022. I would love some feedback and testing there. I just found this issue today after thinking for a while that I should submit my package to nixpkgs. @gbytedev I'd be happy to add you as a maintainer if you're interested! |
|
@star-szr Feel free add me; I'm happy to deprecate my NUR package and support the upstream one as it has just been merged apparently. 🙌 |
|
@gbytedev I don't see you in https://raw.githubusercontent.com/NixOS/nixpkgs/master/maintainers/maintainer-list.nix, but if you'd like to help maintain the newly merged package, please open a PR to add yourself to the maintainer list and to the ddev package and I'd be happy to give it a +1. Thanks! |
|
I have nothing to add, except for thanks for all the work on getting this package working. I lacked the skills necessary to make this a proper release. I'll be glad to help test once it goes live |
Description of changes
This PR is for adding a new package: ddev
"Docker-based local PHP + Node.js web development environments"
Homepage: https://ddev.readthedocs.io/en/stable/
Source: https://github.com/drud/ddev
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes