stdenv: add runPhase function #21060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezgeg
reviewed
Dec 11, 2016
| # function named $phase. | ||
| eval "${!phase:-$phase}" | ||
|
|
||
| if [ "$curPhase" = unpackPhase ]; then |
There was a problem hiding this comment.
I think this should be checking for $phase instead of $curPhase.
There was a problem hiding this comment.
oh I missed that one, pretty strange that I didn't notice any build issues.
There was a problem hiding this comment.
I guess $curPhase is global and this is only called from a single place (where $phase == $curPhase)..
dezgeg
reviewed
Dec 11, 2016
| fi | ||
|
|
||
| stopNest | ||
| runPhase $curPhase |
this is useful for running phases inside a nix-shell
|
Another solution for this behaviour would be to do this in the functions for each phase, that way we would get the expected behaviour without having to use the |
LnL7
force-pushed
the
stdenv-run-phase
branch
from
9c290b3
to
5f5d181
Compare
|
I think it's better if this is fixed in the phases, that way it will work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is useful for running phases inside a nix-shell, using
buildPhasefor example will always execute make even when a derivation has a custom buildPhase.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"stdenv.mkDerivation