-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildGoPackage: remove go version from name #21111
Conversation
@zimbatm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lethalman, @wkennington and @kamilchm to be potential reviewers. |
I was also wondering about renaming |
As a user installing the program it's not interesting what go version it was compiled against. Not more interesting than any other potential dependencies. It also makes it harder to install or update the package.
c95e953
to
08c853b
Compare
Yeah maybe. I'm not convinced the naming for I'll merge this PR for now and we can consider the naming bit later on. |
The application term was the only thing stopping me from making PR :/ I feel it awkward too but I couldn't find a better name. |
Yeah same thinking here. Also how did we go from In my mind there are two broad kind of derivations: those that are designed to be installed using nix-env and the others. For the first category we care about:
For the second category:
Libraries sit a bit in between both depending on how they are being used. nixpkgs used to host a lot of libraries intended to be used by the user, like the stackage layers. Nowadays I think we decided to focus on shipping packages and solve the library problems a bit differently, using |
Motivation for this change
As a user installing the program it's not interesting what go version it
was compiled against. Not more interesting than any other potential
dependencies. It also makes it harder to install or update the package.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)