Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp: disable flaky test #211412

Merged
merged 1 commit into from
Jan 19, 2023
Merged

aws-sdk-cpp: disable flaky test #211412

merged 1 commit into from
Jan 19, 2023

Conversation

domenkozar
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@roberth
Copy link
Member

roberth commented Jan 18, 2023

There's a typo in the commit message that will confuse ofborg and not find the attribute to build.

I think it should be aws-sdk-cpp, according to nix's flake.nix.

@domenkozar domenkozar changed the title aws-swk-cpp: disable flaky test aws-sdk-cpp: disable flaky test Jan 18, 2023
domenkozar added a commit to domenkozar/nix that referenced this pull request Jan 18, 2023
@ofborg ofborg bot requested a review from edolstra January 18, 2023 15:56
@domenkozar
Copy link
Member Author

Given that people are failing to build Nix, I'm merging this to unblock them.

@roberth
Copy link
Member

roberth commented Jan 19, 2023

Thanks!

@domenkozar domenkozar deleted the aws-sdk-remove-test branch January 20, 2023 17:08
domenkozar added a commit to domenkozar/nix that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants