Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certbot: 0.6.0 -> 0.9.3 #21174

Closed
wants to merge 2 commits into from
Closed

Conversation

phunehehe
Copy link
Contributor

@phunehehe phunehehe commented Dec 15, 2016

Motivation for this change

Because new stuff :)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@phunehehe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nckx, @domenkozar and @benley to be potential reviewers.

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks simp_le, see https://travis-ci.org/NixOS/nixpkgs/jobs/184230379#L3181.

Could you test simp_le with the new certbot/acme version? You would need to patch the requirements.txt to allow certbot 0.9.x.

@phunehehe
Copy link
Contributor Author

It may be a bit premature to say this, but the fact that simp_le seems unmaintained is partly the reason I'm moving to certbot.

To fix this build I think the best way is to switch to a better maintained fork https://github.com/zenhack/simp_le. I just pushed a commit that does this. The package builds, but I'll leave the testing to some real user.

@Mic92 Mic92 closed this in 5a31ad1 Dec 21, 2016
@Mic92
Copy link
Member

Mic92 commented Dec 21, 2016

Thanks!

@phunehehe phunehehe deleted the certbot-0.9.3 branch December 24, 2016 06:43
@Mic92 Mic92 mentioned this pull request Jan 29, 2017
7 tasks
rimmington pushed a commit to rimmington/nixpkgs that referenced this pull request Jan 30, 2017
kuba/simp_le seems unmaintained.
fixes NixOS#21174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants