-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certbot: 0.6.0 -> 0.9.3 #21174
certbot: 0.6.0 -> 0.9.3 #21174
Conversation
@phunehehe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nckx, @domenkozar and @benley to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks simp_le, see https://travis-ci.org/NixOS/nixpkgs/jobs/184230379#L3181.
Could you test simp_le with the new certbot/acme version? You would need to patch the requirements.txt
to allow certbot 0.9.x.
kuba/simp_le seems unmaintained
c54531d
to
c16ac10
Compare
It may be a bit premature to say this, but the fact that simp_le seems unmaintained is partly the reason I'm moving to certbot. To fix this build I think the best way is to switch to a better maintained fork https://github.com/zenhack/simp_le. I just pushed a commit that does this. The package builds, but I'll leave the testing to some real user. |
Thanks! |
kuba/simp_le seems unmaintained. fixes NixOS#21174
Motivation for this change
Because new stuff :)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)