Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nssModules: include correct systemd output #21175

Merged
merged 1 commit into from Dec 15, 2016
Merged

nssModules: include correct systemd output #21175

merged 1 commit into from Dec 15, 2016

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 15, 2016

Motivation for this change

fixes libnss_myhost, libnss_mymachines, libnss_resolve are located here.
Maybe requires a backport?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

fixes libnss_myhost, libnss_mymachines, libnss_resolve are located here
@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rickynils and @bjornfor to be potential reviewers.

@Mic92
Copy link
Member Author

Mic92 commented Dec 15, 2016

fixes #18183

@vcunat
Copy link
Member

vcunat commented Dec 15, 2016

.out is the default output, I believe.

@Mic92
Copy link
Member Author

Mic92 commented Dec 15, 2016

@vcunat it used systemd-lib before, which only includes libudev and libsystemd. You can see the difference by using: systemctl cat nscd

@vcunat
Copy link
Member

vcunat commented Dec 15, 2016

Oh, I see, it uses makeLibraryPath, which prefers .lib to .out, of course.

@Mic92 Mic92 merged commit 3b763fe into NixOS:master Dec 15, 2016
@Mic92 Mic92 deleted the nss branch December 15, 2016 19:23
@vcunat
Copy link
Member

vcunat commented Dec 15, 2016

I suppose the situation on 16.09 would be the same?

@Mic92
Copy link
Member Author

Mic92 commented Dec 15, 2016

@vcunat yes, but I cannot at the moment cherry-pick and test it there.

vcunat pushed a commit that referenced this pull request Dec 18, 2016
fixes libnss_myhost, libnss_mymachines, libnss_resolve are located here

(cherry picked from commit 3b763fe)
/cc #21175.  I confirm the libraries are located in .out on 16.09 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants