Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot: add badges plugin #211969

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

JulienMalka
Copy link
Member

@JulienMalka JulienMalka commented Jan 21, 2023

Description of changes

Added buildbot badges plugin.
Currently buildbot it broken so this depends on #211854.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1775

@SuperSandro2000
Copy link
Member

Do you have an idea why the test are failing for x86_64-linux?

@JulienMalka
Copy link
Member Author

@ofborg test buildbot

@JulienMalka
Copy link
Member Author

@SuperSandro2000 I think buildbot was broken when I submitted this PR, let's see if tests are passing now.

@JulienMalka
Copy link
Member Author

Looks like test are ok now @SuperSandro2000

@RaitoBezarius
Copy link
Member

@ofborg eval

@RaitoBezarius RaitoBezarius merged commit 474df7c into NixOS:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants