Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nghttp2: fix build #211971

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jan 21, 2023

Description of changes

Apparently #205395 broke the nghttp2 python package (and made it to stable too, hence the backport label). Python bindings now need an explicit flag to enable.

However, note from nghttp2/nghttp2#1846 that these bindings are going to be removed entirely in the next release.

Added python package to passthru.tests to prevent this happening again.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

python bindings now need an explicit flag to enable (but are
going to be removed entirely in the next release)
@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

@vcunat
Copy link
Member

vcunat commented Jan 31, 2023

Thanks. I suppose it will soon get dropped on nixpkgs master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants