New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-gyp: fix darwin build without xcode #21274
Conversation
What is the origin of this patch? Did you write this yourself, or does it come from elsewhere? |
It's handwritten based on the previous patch, but it looks like this still needs the CLT 😞 |
@LnL What happened when you tried to use |
The MacOSX sdk, didn't really look any further since I thought the patch worked. |
Is this ready or work in progress? |
I guess we could merge this in, this won't work on hydra yet but you don't need a full xcode install anymore. |
@LnL7 could you check my branch here: https://github.com/retrry/nixpkgs/tree/fix-gyp-darwin? It has one commit https://github.com/retrry/nixpkgs/commit/cd5955db68615f48e3b1feb6fa59f650ff574bcc. With it everything compiles on my machine, which doesn't have xcode installed. Maybe add that commit to your pull request and that would be enough? |
@retrry Yes, that looks like the missing part! It's actually the only change that seems to be required. |
I noticed some things that use gyp still fail, I want to compare if my changes help in those cases or if it's unrelated. |
Yay, this fixed |
Motivation for this change
This should make
http-parser
and all of it's dependencies build on hydra.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)