Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-gyp: fix darwin build without xcode #21274

Merged
merged 1 commit into from Jan 11, 2017
Merged

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 18, 2016

Motivation for this change

This should make http-parser and all of it's dependencies build on hydra.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • macOS
    • No Changes
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 18, 2016
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig and @FRidh to be potential reviewers.

@FRidh
Copy link
Member

FRidh commented Dec 19, 2016

What is the origin of this patch? Did you write this yourself, or does it come from elsewhere?

@LnL7
Copy link
Member Author

LnL7 commented Dec 19, 2016

It's handwritten based on the previous patch, but it looks like this still needs the CLT 😞

@acowley
Copy link
Contributor

acowley commented Dec 20, 2016

@LnL What happened when you tried to use xcbuild? You said it didn't like an empty path at some point, is that right?

@LnL7
Copy link
Member Author

LnL7 commented Dec 20, 2016

The MacOSX sdk, didn't really look any further since I thought the patch worked.

@FRidh
Copy link
Member

FRidh commented Jan 2, 2017

Is this ready or work in progress?

@LnL7
Copy link
Member Author

LnL7 commented Jan 2, 2017

I guess we could merge this in, this won't work on hydra yet but you don't need a full xcode install anymore.

@retrry
Copy link
Contributor

retrry commented Jan 6, 2017

@LnL7 could you check my branch here: https://github.com/retrry/nixpkgs/tree/fix-gyp-darwin? It has one commit https://github.com/retrry/nixpkgs/commit/cd5955db68615f48e3b1feb6fa59f650ff574bcc. With it everything compiles on my machine, which doesn't have xcode installed. Maybe add that commit to your pull request and that would be enough?

@LnL7
Copy link
Member Author

LnL7 commented Jan 6, 2017

@retrry Yes, that looks like the missing part!

It's actually the only change that seems to be required.

@retrry
Copy link
Contributor

retrry commented Jan 7, 2017

@FRidh @LnL7 so can we get this merged? :) I would really like to get rust stuff working on Darwin again.

@FRidh
Copy link
Member

FRidh commented Jan 7, 2017

@retrry that's up to @LnL7

@LnL7
Copy link
Member Author

LnL7 commented Jan 7, 2017

I noticed some things that use gyp still fail, I want to compare if my changes help in those cases or if it's unrelated.

@LnL7 LnL7 self-assigned this Jan 7, 2017
@LnL7 LnL7 merged commit 51beb93 into NixOS:master Jan 11, 2017
@LnL7 LnL7 deleted the darwin-gyp branch January 11, 2017 07:51
@acowley
Copy link
Contributor

acowley commented Jan 11, 2017

Yay, this fixed cargo as we had hoped! Thanks, @LnL7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants