WIP: Roundup 14 #21335
Merged
WIP: Roundup 14 #21335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
added
1.severity: security
2.status: work-in-progress
9.needs: port to stable
grahamc
commented
Dec 21, 2016
| # XSA-197 | ||
| # they didn't apply, and there are plenty of other patches here | ||
| # to get this deployed as-is. | ||
| xenPatches = [ ./0001-libxl-Spice-image-compression-setting-support-for-up.patch |
There was a problem hiding this comment.
@NeQuissimus I found surprises today :P I've been missing these for ages.
There was a problem hiding this comment.
Oh wow... Are they separate?
There was a problem hiding this comment.
Sorry? I don't understand.
There was a problem hiding this comment.
lol, I don't know anymore what I meant either :D
NeQuissimus
approved these changes
Dec 21, 2016
| # XSA-197 | ||
| # they didn't apply, and there are plenty of other patches here | ||
| # to get this deployed as-is. | ||
| xenPatches = [ ./0001-libxl-Spice-image-compression-setting-support-for-up.patch |
There was a problem hiding this comment.
Oh wow... Are they separate?
abbradar
reviewed
Dec 21, 2016
| @@ -19,11 +19,11 @@ with lib; | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "samba-${version}"; | |||
| version = "4.4.6"; | |||
| version = "4.4.8"; | |||
There was a problem hiding this comment.
Do we still want this given that b0a1028 is in staging?
|
Nikolay Amiantov <notifications@github.com> writes:
abbradar commented on this pull request.
> @@ -19,11 +19,11 @@ with lib;
stdenv.mkDerivation rec {
name = "samba-${version}";
- version = "4.4.6";
+ version = "4.4.8";
Do we still want this given that
b0a1028
is in staging?
No :) removed the commit.
…
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#21335 (review)
|
fpletz
approved these changes
Dec 21, 2016
Switching to git tags means we don't get pre-generated configure scripts. Thusly, run bootstrap ourselves. For NixOS#21289 For CVE-2016-8863 (remote code execution)
- XSA-190 - XSA-191 - XSA-192 - XSA-193 - XSA-195 - XSA-196 - XSA-198 - XSA-200 - XSA_202 - XSA-204
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#21289
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)