Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffutils: 3.8 -> 3.9 #213421

Merged
merged 1 commit into from Feb 23, 2023
Merged

diffutils: 3.8 -> 3.9 #213421

merged 1 commit into from Feb 23, 2023

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 29, 2023

Changes: https://savannah.gnu.org/forum/forum.php?forum_id=10282

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi marked this pull request as draft January 29, 2023 19:29
@trofi
Copy link
Contributor Author

trofi commented Jan 29, 2023

Breaks at least groff tests:

groff> FAIL: contrib/gdiffmk/tests/gdiffmk_tests.sh
groff> ============================================
groff> result.1 TEST FAILED
groff> 5c5
groff> < .mc |
groff> ---
groff> > file1 only
groff> 8d7
groff> < .mc
groff> 10d8
groff> < .mc +

Filed upstream report: https://savannah.gnu.org/bugs/index.php?63726

Switching to draft for now.

@trofi
Copy link
Contributor Author

trofi commented Feb 20, 2023

diffutils regression https://git.savannah.gnu.org/cgit/groff.git/commit/?id=10274fb69e517b2c4b10fcd0ba3347e5bd0eefd7. Will try to backport today.

@trofi trofi marked this pull request as ready for review February 20, 2023 19:20
@trofi
Copy link
Contributor Author

trofi commented Feb 20, 2023

Can build groff now. Ready for review.

@trofi trofi merged commit 1dd9fc2 into NixOS:staging Feb 23, 2023
@trofi trofi deleted the diffutils-update branch February 23, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant