Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin(go-packages): init at 20.8 #213522

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

wineee
Copy link
Member

@wineee wineee commented Jan 30, 2023

Description of changes

Part of linuxdeepin/dde-nixos#9

go-lib: Library containing many useful go routines for things such as glib, gettext, archive, graphic, etc
go-dbus-factory : Generate go binding of D-Bus interfaces
go-gir-generator: Generate static golang bindings for GObject
deepin-pw-check: Tool to verify the validity of the password
deepin-gettext-tools(python/perl): Translation file processing utils for DDE development

dde-api / dde-daemon don't packaged in this pr

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wineee
Copy link
Member Author

wineee commented Jan 30, 2023

@ofborg build deepin

@wineee wineee force-pushed the deepin-go-package branch 2 times, most recently from 9b473f5 to 7914ffd Compare February 1, 2023 02:41
@wineee wineee force-pushed the deepin-go-package branch 4 times, most recently from 08c772c to 076cdbc Compare February 3, 2023 09:47
@@ -25,6 +34,15 @@ let
deepin-editor = callPackage ./apps/deepin-editor { };
deepin-terminal = callPackage ./apps/deepin-terminal { };

#### Go Packages
go-lib = callPackage ./go-package/go-lib { inherit replaceAll; };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it acceptable to place functions like this? @SuperSandro2000

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is fully correct but we can fix that when more things are accumulated.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1803

@SuperSandro2000
Copy link
Member

@ofborg build deepin.deepin-pw-check deepin.go-gir-generator deepin.deepin-gettext-tools deepin.go-dbus-factory deepin.go-lib deepin.go-dbus-factory

@SuperSandro2000 SuperSandro2000 merged commit 7a033d6 into NixOS:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants