digikam: Add patch to fix compilation against Lensfun 0.3.2 #21366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sh01, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cillianderoiste, @jraygauthier and @ttuegel to be potential reviewers. |
| @@ -1,4 +1,4 @@ | |||
| { stdenv, fetchurl, automoc4, boost, shared_desktop_ontologies, cmake | |||
| { stdenv, fetchurl, pkgs, automoc4, boost, shared_desktop_ontologies, cmake | |||
There was a problem hiding this comment.
You should depend on fetchpatch instead of the whole pkg.
There was a problem hiding this comment.
seems fine to me otherwise.
sh01
force-pushed
the
digikam_patch_lensfun_0.3.2
branch
from
47d26fe
to
4efd108
Compare
|
I've rewritten this to not import all of pkgs and instead take fetchpatch directly. PTAL. |
|
The Travis failure is a build time limit overrun. I don't think it indicates a real issue. |
|
This seems fine to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Digikam4 compilation was broken by updating Lensfun to 0.3.2. This adds a patch from upstream to fix it.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)