tmuxp: 1.23.0 -> 1.27.0

[otavio]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[superherointj]

Result of nixpkgs-review pr 213891 run on x86_64-linux 1

4 packages failed to build:

• arsenal
• python310Packages.libtmux
• python311Packages.libtmux
• tmuxp

[otavio]

I fixed one failing test but still fighting with this error:

============================= test session starts ==============================
platform linux -- Python 3.10.9, pytest-7.2.0, pluggy-1.0.0
rootdir: /build/source, configfile: setup.cfg
plugins: libtmux-0.21.0, rerunfailures-10.3
collected 252 items

tests/test_common.py ....................                                [  7%]
tests/test_dataclasses.py ..                                             [  8%]
tests/test_pane.py .......                                               [ 11%]
tests/test_pytest_plugin.py .                                            [ 11%]
tests/test_server.py ............F......                                 [ 19%]
tests/test_session.py ..........................s                        [ 30%]
tests/test_test.py .....                                                 [ 32%]
tests/test_tmuxobject.py .....                                           [ 34%]
tests/test_version.py ..................                                 [ 41%]
tests/test_window.py ........................s                           [ 51%]
tests/legacy_api/test_common.py ....................                     [ 59%]
tests/legacy_api/test_pane.py .....                                      [ 61%]
tests/legacy_api/test_server.py ..................                       [ 68%]
tests/legacy_api/test_session.py ..........................s             [ 78%]
tests/legacy_api/test_test.py .....                                      [ 80%]
tests/legacy_api/test_tmuxobject.py .....                                [ 82%]
tests/legacy_api/test_version.py ..................                      [ 90%]
tests/legacy_api/test_window.py ........................s                [100%]

=================================== FAILURES ===================================
________________________ test_new_session_width_height _________________________

server = Server(socket_name=libtmux_testson36ubg)

    @pytest.mark.skipif(has_version("3.2"), reason="Wrong width returned with 3.2")
    def test_new_session_width_height(server: Server) -> None:
        """Server.new_session creates and returns valid session running with
        specified width /height"""
        cmd = "/usr/bin/env PS1='$ ' sh"
>       mysession = server.new_session(
            "test_new_session_width_height",
            window_command=cmd,
            x=32,
            y=32,
        )

tests/test_server.py:135:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/nix/store/42bk3lrxw9yxnrfry13gxiclbiji2vz6-python3.10-libtmux-0.21.0/lib/python3.10/site-packages/libtmux/server.py:494: in new_session
    return Session.from_session_id(
/nix/store/42bk3lrxw9yxnrfry13gxiclbiji2vz6-python3.10-libtmux-0.21.0/lib/python3.10/site-packages/libtmux/session.py:85: in from_session_id
    session = fetch_obj(
/nix/store/42bk3lrxw9yxnrfry13gxiclbiji2vz6-python3.10-libtmux-0.21.0/lib/python3.10/site-packages/libtmux/neo.py:234: in fetch_obj
    obj_formatters_filtered = fetch_objs(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

server = Server(socket_name=libtmux_testson36ubg), list_cmd = 'list-sessions'
list_extra_args = None

    def fetch_objs(
        server: "Server", list_cmd: "ListCmd", list_extra_args: "ListExtraArgs" = None
    ) -> OutputsRaw:
        formats = list(Obj.__dataclass_fields__.keys())

        cmd_args: t.List[t.Union[str, int]] = list()

        if server.socket_name:
            cmd_args.insert(0, f"-L{server.socket_name}")
        if server.socket_path:
            cmd_args.insert(0, f"-S{server.socket_path}")
        tmux_formats = [f"#{{{f}}}{FORMAT_SEPARATOR}" for f in formats]

        tmux_cmds = [
            *cmd_args,
            list_cmd,
        ]

        if list_extra_args is not None and isinstance(list_extra_args, t.Iterable):
            tmux_cmds.extend(list(list_extra_args))

        tmux_cmds.append("-F%s" % "".join(tmux_formats))

        proc = tmux_cmd(*tmux_cmds)  # output

        if proc.stderr:
>           raise exc.LibTmuxException(proc.stderr)
E           libtmux.exc.LibTmuxException: ['no server running on /tmp/tmux-1000/libtmux_testson36ubg']

/nix/store/42bk3lrxw9yxnrfry13gxiclbiji2vz6-python3.10-libtmux-0.21.0/lib/python3.10/site-packages/libtmux/neo.py:210: LibTmuxException

[superherointj]

One option would be to skip test test_new_session_width_height.

[otavio]

Result of nixpkgs-review pr 213891 run on x86_64-linux 1

4 packages built:

• arsenal
• python310Packages.libtmux
• python311Packages.libtmux
• tmuxp