multipass: init at 1.11.0 #214193
multipass: init at 1.11.0 #214193
Conversation
|
Thanks for the rapid review @AndersonTorres! I think I've addressed all your feedback. |
|
I've added some simple tests here; I initially added a test that actually started a VM and tested it, but since Multipass fetches the VM images from the internet, the tests don't pass, so I've removed them for now. |
Thank you a lot for this! Can you rebase your branch into three commits:
separating package and module if possible :). (you can keep tests in the module commit, if it's too annoying, make it two commits with |
Will address your feedback, then rebase. Thanks! |
It is recommended to put the tests in its own separated commit. |
|
I've restricted this to |
|
And, before I forget: welcome to Nixpkgs! |
|
Thanks for all the help! 😄 |
| repo = "multipass"; | ||
| rev = "refs/tags/v${version}"; | ||
| sha256 = "sha256-2d8piIIecoSI3BfOgAVlXl5P2UYDaNlxUgHXWbnSdkg="; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
Using submodules is problematic because eg we are using a two year old fork of libssh https://github.com/canonical/multipass/blob/main/.gitmodules#L9-L11
There was a problem hiding this comment.
Please, can you open an issue documenting your remarks post-merge?
There was a problem hiding this comment.
As this is directly related to this PR, I think that is unnecessary.
|
|
||
| nativeBuildInputs = [ | ||
| cmake | ||
| git |
Description of changes
Adds a multipass package and NixOS module.
Things done
aarch64-linuxx86_64-darwinaarch64-darwinFor non-Linux: Issandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes