rustc: apply patch to fix delay_span_bug ICE

[winterqt]

Description of changes

https://hydra.nixos.org/build/207931877
rust-lang/rust#107691
rust-lang/rust#107688

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin, nix-build -A vector
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[winterqt]

@NixOS/rust The upstream patch hasn't been approved. Assuming we have to land this today to get it in for this cycle (along with the scheduled OpenSSL update), we have two options:

1. Let vector (the only package, at least AFAIK, that's affected by this) regress for hopefully just one cycle, as people can always just pin it.
2. Revert the bump.

Thoughts?

[figsoda]

How urgent is the OpenSSL update? Looking at hydra, the regression doesn't seem to effect much more packages, perhaps we can just add back rust 1.66 for vector if we can't apply the patch in time?

[winterqt]

How urgent is the OpenSSL update?

High severity per the announcement.

perhaps we can just add back rust 1.66 for vector if we can't apply the patch in time?

I'd be open to that since it won't even have to hit staging.

[figsoda]

changes lgtm, just waiting for upstream to be approved

[winterqt]

@figsoda Upstream approved them, which is why I undrafted this.

[figsoda]

Ah I misunderstood rust-lang/rust#107688 (comment), this is good to go once CI's done

[figsoda]

@ofborg build vector

[winterqt]

Vector built on both Linux architectures, and Darwin is timing out as expected. Let's do it.

[figsoda]

was just about to do that lol