{deepin/dde}-kwin: init #215075
Merged
{deepin/dde}-kwin: init #215075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wineee
force-pushed
the
kwin
branch
2 times, most recently
from
2c2c8c8
to
6e4e222
Compare
|
@ofborg build deepin.deepin-kwin |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1811 |
NickCao
reviewed
Feb 11, 2023
wineee
force-pushed
the
kwin
branch
3 times, most recently
from
295497f
to
fffebe6
Compare
49 tasks
wineee
commented
Apr 11, 2023
wegank
approved these changes
Apr 26, 2023
NickCao
reviewed
Apr 28, 2023
Comment on lines
+43
to
+46
| substituteInPlace deepin-wm-dbus/deepinwmfaker.cpp \ | ||
| --replace "/usr/lib/deepin-daemon" "/run/current-system/sw/lib/deepin-daemon" \ | ||
| --replace "/usr/share/backgrounds" "/run/current-system/sw/share/backgrounds" \ | ||
| --replace "/usr/share/wallpapers" "/run/current-system/sw/share/wallpapers" |
There was a problem hiding this comment.
Still not happy with this part, but we don't have better alternatives now anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
linuxdeepin/dde-nixos#9
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes