river: 0.2.3 -> 0.2.4

[adamcstephens]

Description of changes

https://github.com/riverwm/river/releases/tag/v0.2.4

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[adamcstephens]

Result of nixpkgs-review pr 215709 run on aarch64-linux 1

2 packages built:

• river
• rivercarro

[rodrgz]

x86_64:

error: builder for '/nix/store/4lgap5ik2qny53bny8np14jddqrp0ywk-river-0.2.4.drv' failed with exit code 132;
last 8 log lines:
> unpacking sources
> unpacking source archive /nix/store/0zcmis2vrz3fz1i9lslsh42cssccpcdm-source
> source root is source
> patching sources
> building
> no Makefile or custom buildPhase, doing nothing
> installing
> /nix/store/3yfs41f4b60jya2gk6xikx4s97zsxjr0-stdenv-linux/setup: line 1574: 22 Illegal instruction (core dumped) zig build -Drelease-safe -Dcpu=baseline -Dxwayland -Dman-pages --prefix $out install

[moni-dz]

x86_64:

error: builder for '/nix/store/4lgap5ik2qny53bny8np14jddqrp0ywk-river-0.2.4.drv' failed with exit code 132;

   last 8 log lines:

   > unpacking sources

   > unpacking source archive /nix/store/0zcmis2vrz3fz1i9lslsh42cssccpcdm-source

   > source root is source

   > patching sources

   > building

   > no Makefile or custom buildPhase, doing nothing

   > installing

   > /nix/store/3yfs41f4b60jya2gk6xikx4s97zsxjr0-stdenv-linux/setup: line 1574:    22 Illegal instruction     (core dumped) zig build -Drelease-safe -Dcpu=baseline -Dxwayland -Dman-pages --prefix $out install

i would wager that zig in nixpkgs not overriding ZIG_TARGET_MCPU https://github.com/ziglang/zig/blob/a5d25fabdaf7e68f375874b9bda402acaeb9545d/CMakeLists.txt#L115 causing the compiler to be built with -Dcpu=nativeand not -Dcpu=baseline

[adamcstephens]

x86_64-linux builds for me...

Result of nixpkgs-review pr 215709 run on x86_64-linux 1

2 packages built:

• river
• rivercarro

[moni-dz]

it's a problem of feature sets/instructions that @rodrgz cpu just doesn't have compared to what hydra builders have

mind if i get a cat /proc/cpuinfo?

[rodrgz]

I found it a little strange because I was the one who submitted the last PR and everything went well.

processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 158
model name	: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
stepping	: 10
microcode	: 0xf0
cpu MHz		: 4146.302
cache size	: 12288 KB
physical id	: 0
siblings	: 12
core id		: 0
cpu cores	: 6
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 22
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb invpcid_single pti ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust sgx bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp sgx_lc md_clear flush_l1d arch_capabilities
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple pml ept_mode_based_exec
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds mmio_stale_data retbleed
bogomips	: 5199.98
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

[moni-dz]

that's so strange, since your cpu supports the x86-64-v3 feature set

[adamcstephens]

I reproduced the failure on an Intel J3710.

vendor_id   : GenuineIntel
cpu family  : 6
model       : 76
model name  : Intel(R) Pentium(R) CPU  J3710  @ 1.60GHz
stepping    : 4
microcode   : 0x411
cpu MHz     : 2640.000
cache size  : 1024 KB
physical id : 0
siblings    : 4
core id     : 3
cpu cores   : 4
apicid      : 6
initial apicid  : 6
fpu     : yes
fpu_exception   : yes
cpuid level : 11
wp      : yes
flags       : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology tsc_reliable nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm sse4_1 sse4_2 movbe popcnt tsc_deadline_timer aes rdrand lahf_lm 3dnowprefetch epb pti ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid tsc_adjust smep erms dtherm ida arat md_clear
vmx flags   : vnmi preemption_timer invvpid ept_x_only flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest
bugs        : cpu_meltdown spectre_v1 spectre_v2 mds msbds_only mmio_unknown
bogomips    : 3200.00
clflush size    : 64
cache_alignment : 64
address sizes   : 36 bits physical, 48 bits virtual

[adamcstephens]

Zig PR is merged so we should move forward with this.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1820

[rodrgz]

Now it is working fine!