Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtitleedit: init at 3.6.11 #215877

Merged
merged 2 commits into from
Feb 16, 2023
Merged

subtitleedit: init at 3.6.11 #215877

merged 2 commits into from
Feb 16, 2023

Conversation

paveloom
Copy link
Member

@paveloom paveloom commented Feb 11, 2023 •
edited

Description of changes
  1. Add myself to the maintainers list
  2. Add a Mono wrapper for the portable version of Subtitle Edit
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@paveloom
Copy link
Member Author

Result of nixpkgs-review pr 215877 run on x86_64-linux 1

1 package built:
  • subtitleedit

@paveloom paveloom force-pushed the subtitleedit branch 2 times, most recently from a097418 to fc62df6 Compare February 11, 2023 21:18
sikmir
sikmir reviewed Feb 11, 2023
View reviewed changes
pkgs/applications/video/subtitleedit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/subtitleedit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/subtitleedit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/subtitleedit/default.nix Outdated Show resolved Hide resolved
@paveloom paveloom force-pushed the subtitleedit branch 2 times, most recently from c5f2b5c to 880e234 Compare February 11, 2023 21:26
@paveloom paveloom force-pushed the subtitleedit branch 3 times, most recently from d4b5eec to 4536387 Compare February 13, 2023 12:52
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1829

@paveloom paveloom force-pushed the subtitleedit branch 2 times, most recently from 1306803 to 04efc9b Compare February 14, 2023 15:51
@SuperSandro2000 SuperSandro2000 merged commit b2c3a4d into NixOS:master Feb 16, 2023
@paveloom paveloom deleted the subtitleedit branch February 17, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paveloom @nixos-discourse @sikmir @SuperSandro2000 @Janik-Haag