slop: fix build

[superherointj]

slop: fix build

• FindGLEW.cmake Module silently tries to include glew-config.cmake. If it succeeds, then it stop and return to the caller. However, glew-config.cmake only sets GLEW::GLEW, resulting in missing glew shared library at link time.

References:

• Fix linking of GLEW library naelstrof/slop#135
• https://gitlab.exherbo.org/DanySpin97/danyspin97-exheres/-/issues/2

[NickCao]

Can we use fetchpatch instead?

[NickCao]

Result of nixpkgs-review pr 216371 run on x86_64-linux 1

8 packages built:

• capture
• giph
• maim
• pb_cli
• recapp
• screenkey
• slop
• yaxg

[NickCao]

Waiting for ofborg.

[winterqt]

@superherointj Do you happen to know what caused this to regress off the top of your head, as it regressed very recently? No changes to our GLEW package stick out, and there's been no changes to slop other than this one.

If not, I can bisect, but was just hoping you'd know :)

[superherointj]

@superherointj Do you happen to know what caused this to regress off the top of your head, as it regressed very recently? No changes to our GLEW package stick out, and there's been no changes to slop other than this one.

If not, I can bisect, but was just hoping you'd know :)

Seems:

809f21a32f3f92c349be781f75c6459dd29902c3 is the first bad commit
commit 809f21a32f3f92c349be781f75c6459dd29902c3
Author: Anderson Torres <torres.anderson.85@protonmail.com>
Date:   Sat Jan 21 12:38:35 2023 -0300

    cmake: 3.24.3 -> 3.25.1

 .../cmake/002-application-services.diff            | 36 ++++++++++------------
 .../tools/build-managers/cmake/default.nix         |  4 +--
 2 files changed, 18 insertions(+), 22 deletions(-)

[vcunat]

IIRC there were multiple packages regressing with failure to find glew, in that rebuild batch (PR #214010).

[winterqt]

The issue is a bit more nuanced than this patch shows. I'll see if I can find those and fix them along with this one. Thanks.