Disable tests for zope.configuration on Python3.6 #21672

Open
wants to merge 1 commit into
from

Projects

None yet

4 participants

@berdario
Contributor
berdario commented Jan 5, 2017 edited
Motivation for this change

zopefoundation/zope.configuration#16
pypa/setuptools#912

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@berdario berdario Disable tests for zope.configuration on Python3.6 f67a059
@mention-bot

@berdario, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Member
FRidh commented Jan 5, 2017

This is related to an issue I opened a while ago. It was only partially solved in setuptools at the time. Am I correct that it was only the tests that failed but the package did actually function?

@@ -27230,6 +27230,8 @@ EOF
sha256 = "1x9dfqypgympnlm25p9m43xh4qv3p7d75vksv9pzqibrb4cggw5n";
};
+ doCheck = pythonOlder "3.6";
@FRidh
FRidh Jan 5, 2017 Member

add a comment here explaining why

@globin
Member
globin commented Jan 19, 2017

Fails on 3.5, too.

@berdario
Contributor
@globin
Member
globin commented Jan 19, 2017

@FRidh I think I'm having the same issue while trying to package mailman3 with "nested modules" (e.g. flufl.bounce not found) at runtime, not only when testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment