Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub: unstable-2022-04-04 -> unstable-2022-12-01 #217636

Merged
merged 1 commit into from
Apr 12, 2023
Merged

hub: unstable-2022-04-04 -> unstable-2022-12-01 #217636

merged 1 commit into from
Apr 12, 2023

Conversation

9999years
Copy link
Contributor

The upstream is unmaintained. Update to the latest master commit (it's just a dependency version bump, but might as well while I'm here). Also apply a few patches to fix shell completions.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

@ofborg ofborg bot requested a review from globin February 22, 2023 07:34
@9999years 9999years mentioned this pull request Feb 28, 2023
Open
@SuperSandro2000
Copy link
Member

@ofborg eval
@ofborg build hub

SuperSandro2000
SuperSandro2000 requested changes Apr 1, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you take a look why the hub test is now failing?

@9999years
Copy link
Contributor Author

hub version prints out this:

git version 2.40.0
hub version 2.14.2

but the test expects it to report hub version unstable-2022-12-01. Not sure what the best fix is here.

@SuperSandro2000
Copy link
Member

but the test expects it to report hub version unstable-2022-12-01. Not sure what the best fix is here.

I think we need to patch the version in the source code.

@9999years
Copy link
Contributor Author

Maybe we can make it something a bit more accurate like 2.14.2+38bcd4ae.

@SuperSandro2000
Copy link
Member

Maybe we can make it something a bit more accurate like 2.14.2+38bcd4ae.

The format is described in the contributing guide and that format is actually more wrong confusing because depending how far the commit is in the future, it does not have much to do with the last release version.

@9999years
Copy link
Contributor Author

9999years commented Apr 11, 2023 •
edited

I see. I hadn't seen that part of the contributing guide before, thanks for the pointer.

@9999years
hub: unstable-2022-04-04 -> unstable-2022-12-01
36fbc69 
The upstream is unmaintained. Update to the latest `master` commit (it's
just a dependency version bump, but might as well while I'm here).
Also apply a few patches to fix shell completions.
@SuperSandro2000 SuperSandro2000 merged commit 9df71c7 into NixOS:master Apr 12, 2023
8 checks passed
@9999years 9999years deleted the fix-hub-completions branch April 13, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@globin globin Awaiting requested review from globin

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@9999years @SuperSandro2000