-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mandoc: change OSNAME to Nixpkgs to match groff #217705
Conversation
In general the man pages do not care what OS and manual they are shipped with, so they don't get to choose the names of them. We were tempted to do so, as we had inconsistently chosen OS names for the mandoc and man-db/groff implementations. Since this has been rectified since, we can just drop this boilerplate from the man pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. we'd prefer to keep the nixos-specific manpages at saying they're for nixos, but we're fine having it either way as long as it's consistent.
side note for completeness:
NixOS )
|
@pennae I was contemplating making a In general, I do feel that if |
@sternenseemann not sure about that to be honest, having these variants would introduce a rendering discrepancy depending on how mandoc/groff are installed (seeing how the only thing we really want to not change at this point is configuration.nix.5 due to its specificity, everything else as you've mentioned can really run and be useful anywhere. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)