Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.dde-daemon: init at 5.14.122 #217806

Merged
merged 1 commit into from Apr 9, 2023
Merged

deepin.dde-daemon: init at 5.14.122 #217806

merged 1 commit into from Apr 9, 2023

Conversation

wineee
Copy link
Member

@wineee wineee commented Feb 23, 2023 •
edited

Description of changes

linuxdeepin/dde-nixos#9
( need help to improve this

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wineee wineee requested a review from romildo February 23, 2023 07:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1870

NickCao
NickCao reviewed Feb 26, 2023
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package just requires really heavy patching, hopefully we can improve the situation upstream. Even in case they don't want to conform to standards like XDG, at least they can factor out the hardcoded paths into a common package, to ease patching.

pkgs/desktops/deepin/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/deepin/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/0001-fix-wrapped-name-for-verifyExe.patch Outdated Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/0002-fix-PATH-when-was-launched-by-dbus.patch Outdated Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/0002-fix-PATH-when-was-launched-by-dbus.patch Outdated Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/default.nix Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/default.nix Show resolved Hide resolved
pkgs/desktops/deepin/go-package/dde-daemon/default.nix Outdated Show resolved Hide resolved
@wineee wineee force-pushed the dde-daemon branch 9 times, most recently from 569a0e6 to 5781f2e Compare February 27, 2023 08:58
@wineee
Copy link
Member Author

wineee commented Feb 27, 2023

This package just requires really heavy patching, hopefully we can improve the situation upstream. Even in case they don't want to conform to standards like XDG, at least they can factor out the hardcoded paths into a common package, to ease patching.

dde-deamon will be deprecated in the future, (DDE plans to no longer use go), it's not worth spending too much time improving this project

DDE should conform to XDG standards, I add a patch to aviod /run/current-system/sw/share

@wineee wineee force-pushed the dde-daemon branch 4 times, most recently from 2d43b57 to 9fab5a1 Compare March 2, 2023 06:16
@wineee
Copy link
Member Author

wineee commented Mar 2, 2023

@ofborg build deepin.dde-daemon

@wineee wineee requested a review from NickCao March 5, 2023 15:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1916

@wineee wineee marked this pull request as draft March 12, 2023 15:50
@wineee wineee force-pushed the dde-daemon branch 2 times, most recently from dab1e4d to a052f58 Compare April 5, 2023 16:05
@wineee wineee marked this pull request as ready for review April 5, 2023 16:05
@wineee wineee marked this pull request as draft April 5, 2023 16:09
@wineee wineee marked this pull request as ready for review April 6, 2023 07:22
@SuperSandro2000 SuperSandro2000 merged commit 431bf1e into NixOS:master Apr 9, 2023
8 checks passed
@wineee wineee deleted the dde-daemon branch April 9, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@romildo romildo Awaiting requested review from romildo

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wineee @nixos-discourse @AndersonTorres @SuperSandro2000 @NickCao