Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

microsoft-edge: 107.0.1418.52 -> 111.0.1661.44 #218037

Merged
merged 1 commit into from Mar 28, 2023
Merged

microsoft-edge: 107.0.1418.52 -> 111.0.1661.44 #218037

merged 1 commit into from Mar 28, 2023

Conversation

JonaEnz
Copy link
Contributor

@JonaEnz JonaEnz commented Feb 24, 2023

Description of changes

Update Microsoft Edge as microsoft-edge-dev is currently broken.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@JonaEnz
Copy link
Contributor Author

JonaEnz commented Feb 26, 2023

Solves issue #212274

puffnfresh
puffnfresh reviewed Mar 1, 2023
View reviewed changes
pkgs/applications/networking/browsers/microsoft-edge/browser.nix
@@ -126,10 +123,6 @@ stdenv.mkDerivation rec {
--set-rpath "${libPath.libGLESv2}" \
opt/microsoft/${shortName}/libGLESv2.so

patchelf \
--set-rpath "${libPath.libsmartscreen}" \
opt/microsoft/${shortName}/libsmartscreen.so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you've removed this because it breaks dev but by removing it have you broken beta or main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All channels no longer include libsmartscreen.so. Microsoft has deprecated the old version of SmartScreen around version 108.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In support of @JonaEnz's point: Note that libsmartscreenn (with the double n at the end), is apparently the new Microsoft SmartScreen (for example, see source 1 and source 2) and the derivation contained the new SmartScreen already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

@raymens
Copy link
Contributor

raymens commented Mar 5, 2023

Would be great to have this merged.

I ran all 3 instances locally of this PR (stable, beta, dev).
Everything seemed to work fine.

rikhuijzer
rikhuijzer reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@rikhuijzer rikhuijzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is slightly outdated. Running the script from #219395 will give slightly newer versions.

@JonaEnz JonaEnz force-pushed the edge-update branch 2 times, most recently from baeb521 to 8496323 Compare March 10, 2023 18:33
@JonaEnz
Copy link
Contributor Author

JonaEnz commented Mar 10, 2023

I updated the versions using the new script.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1925

@LowYieldFire
Copy link

LowYieldFire commented Mar 21, 2023 •
edited

To get the new copilot features microsoft-edge should be updated to at least version 111.0.1661.41 according to Windows Central

@JonaEnz JonaEnz force-pushed the edge-update branch 3 times, most recently from 8496323 to 23f0e02 Compare March 21, 2023 21:47
@JonaEnz JonaEnz changed the title microsoft-edge: 107.0.1418.52 -> 110.0.1587.50 microsoft-edge: 107.0.1418.52 -> 111.0.1661.44 Mar 21, 2023
@JonaEnz
Copy link
Contributor Author

JonaEnz commented Mar 22, 2023

Updated all versions again.

@SuperSandro2000
Copy link
Member

What is with #218037 (comment) ?

@JonaEnz
Copy link
Contributor Author

JonaEnz commented Mar 24, 2023 •
edited

What is with #218037 (comment) ?

All current branches use the new libsmartscreenn.so exclusively and no longer include libsmartscreen.so.

@SuperSandro2000 SuperSandro2000 merged commit 6566705 into NixOS:master Mar 28, 2023
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

@MGlolenstine MGlolenstine mentioned this pull request Mar 28, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffnfresh puffnfresh puffnfresh left review comments

@rhysmdnz rhysmdnz rhysmdnz approved these changes

@rikhuijzer rikhuijzer rikhuijzer approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@JonaEnz @raymens @nixos-discourse @LowYieldFire @SuperSandro2000 @puffnfresh @rhysmdnz @rikhuijzer