-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
katago: 1.11.0 -> 1.12.4 #218157
Merged
Merged
katago: 1.11.0 -> 1.12.4 #218157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidalgol
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the Katago derivation, but I like the refactoring you've done in the TensorRT Nix code.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
OmnipotentEntity
force-pushed
the
katago-1.12.4
branch
2 times, most recently
from
March 21, 2023 17:20
18deca4
to
a070152
Compare
Added TensorRT backend, refactored backend selection, IMPORTANT also bumps TensorRT version to 8.5.2 for CUDA 11.7 and 11.8. (Per Nvidia's documentation, 8.4.0.6 does not officially support 11.7, but we're using for it. Additionally, KataGo requires 8.5 or better for the new TensorRT backend. 8.4.0.6 remains the default for 11.6 and lower, in interest of not messing things up as much as possible.) New version also adds support for nested residual block networks, such as the b18 network that was used in the UEC.
OmnipotentEntity
force-pushed
the
katago-1.12.4
branch
from
March 21, 2023 21:43
a070152
to
98df16e
Compare
aidalgol
approved these changes
Mar 22, 2023
SuperSandro2000
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added TensorRT backend, refactored backend selection, IMPORTANT also bumps TensorRT version to 8.5.3 for CUDA 11.7 and 11.8. (Per Nvidia's documentation, 8.4.0.6 does not officially support 11.7, but we're using for it. Additionally, KataGo requires 8.5 or better for the new TensorRT backend. 8.4.0.6 remains the default for 11.6 and lower, in interest of not messing things up as much as possible.)
New version also adds support for nested residual block networks, such as the b18 network that was used in the UEC.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)