Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify: 1.0.45 -> 1.0.47 #21856

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Spotify: 1.0.45 -> 1.0.47 #21856

merged 1 commit into from
Jan 13, 2017

Conversation

thall
Copy link
Contributor

@thall thall commented Jan 13, 2017

Motivation for this change

The resource for version 1.0.45 is deleted, resulting in build failure.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@thall, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ftrvxmtrx, @edolstra and @rickynils to be potential reviewers.

@ftrvxmtrx
Copy link
Member

👍

@globin globin merged commit 15d36c1 into NixOS:master Jan 13, 2017
@thanegill
Copy link
Contributor

Can this get ported to stable?

sheenobu pushed a commit to sheenobu/nixpkgs that referenced this pull request Jan 21, 2017
bjornfor pushed a commit that referenced this pull request Jan 21, 2017
(cherry picked from commit 15d36c1)
blajos pushed a commit to blajos/nixpkgs that referenced this pull request Jan 23, 2017
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants