Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fping: enable IPv6 (provides fping6 binary) #21950

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Jan 17, 2017

Motivation for this change

In order to allow my smokeping to monitor IPv6 hosts I require fping6.
This change builds fping as well as fping6 binaries so nothing should break.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@fadenb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rickynils, @fpletz and @bjornfor to be potential reviewers.

@fpletz fpletz merged commit c885570 into NixOS:master Jan 17, 2017
@fpletz fpletz deleted the fping6 branch January 17, 2017 10:54
@fadenb fadenb mentioned this pull request Jan 24, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants