tailscale-systray: init at 2022-10-19

[qbit]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[drupol]

URL: https://github.com/mattn/tailscale-systray

[drupol]

Why is this not building on aarch64-darwin and x86_64-darwin ?

[qbit]

My guess would be one of the deps doesn't build there.

[drupol]

Got the reason:

Cannot nix-instantiate `tailscale-systray' because:
error: Package ‘libayatana-appindicator-0.5.92’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/macstadium-x86-44911362/pkgs/development/libraries/libayatana-appindicator/default.nix:33 is not supported on ‘x86_64-darwin’, refusing to evaluate.

[qbit]

Yep, confirmed - libayatana-appindicator doesn't build on darwin ( platforms = platforms.linux;).

I kinda have to wonder why one would want it on macos though, since the official client offers the same functionality.

[drupol]

How about adding:

  checkPhase = ''
    $GOPATH/bin/tailscale-systray
  '';

?

[qbit]

The check would fail because it can't connect to the display.

running tests

(tailscale-systray:2036): Gtk-WARNING **: 17:32:18.512: cannot open display: 
error: builder for '/nix/store/sz7h333fv8gfs9nsn7mgrjqp5zdq7q4z-tailscale-systray-2022-10-19.drv' failed with exit code 1;
       last 10 log lines:
       > go: downloading github.com/oxtoacart/bpool v0.0.0-20190530202638-03653db5a59c
       > go: downloading github.com/getlantern/hidden v0.0.0-20201229170000-e66e7f878730
       > go: downloading github.com/getlantern/errors v1.0.1
       > go: downloading github.com/getlantern/ops v0.0.0-20200403153110-8476b16edcd6
       > go: downloading github.com/getlantern/context v0.0.0-20190109183933-c447772a6520
       > go: downloading github.com/getlantern/hex v0.0.0-20190417191902-c6586a6fe0b7
       > go: downloading github.com/go-stack/stack v1.8.1
       > running tests
       >
       > (tailscale-systray:2036): Gtk-WARNING **: 17:32:18.512: cannot open display:
       For full logs, run 'nix log /nix/store/sz7h333fv8gfs9nsn7mgrjqp5zdq7q4z-tailscale-systray-2022-10-19.drv'.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/61

[drupol]

Just for the record, there's another systray utils for Tailscale, I'm using it since it has been merged in Nixpkgs, see it at: https://github.com/DeedleFake/trayscale

[06kellyjac]

There's also a gnome extension for a talescale tray

[qbit]

Updated with suggestions, ty!

[06kellyjac]

LGTM

If you need this in 23.05 LMK and we can put a label on this for backporting

[qbit]

All the machines I run it on are on unstable.. it might be nice for others though! :D

[github-actions]

Successfully created backport PR for release-23.05:

• [Backport release-23.05] tailscale-systray: init at 2022-10-19 #235409