jetbrains-toolbox: init at 1.27.3.14493 #220541
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
| libPath = lib.makeLibraryPath [ stdenv.cc.cc.lib glibc xorg.xcbutilkeysyms gcc zlib libsecret xorg.libXext ]; | ||
| extractApp = { name, src }: runCommand "${name}-extracted" | ||
| { | ||
| buildInputs = [ appimageTools.appimage-exec patchelf gcc libcef ]; |
There was a problem hiding this comment.
please split nativeBuildInputs
| --set-rpath "${libPath}:$out/jre/lib:/usr/lib64" \ | ||
| --set-interpreter ${glibc}/lib64/ld-linux-x86-64.so.2 \ | ||
| $out/jetbrains-toolbox | ||
| patchelf --set-interpreter ${glibc}/lib64/ld-linux-x86-64.so.2 $out/glibcversion |
There was a problem hiding this comment.
please see how that is usually done
| } '' | ||
| appimage-exec.sh -x $out ${src}/${name}-${version}/${name} | ||
| patchelf \ | ||
| --set-rpath "${libPath}:$out/jre/lib:/usr/lib64" \ |
There was a problem hiding this comment.
I removed the $out/jre/lib:/usr/lib64 part since it works without them too.
| mkdir -pv $out/share/applications | ||
| mkdir -pv $out/share/icons | ||
| cp -r ${appimageContents}/.DirIcon $out/share/icons/${name}.svg | ||
| cp -r ${desktopItem}/share/applications/* $out/share/applications/ |
There was a problem hiding this comment.
Please use installDesktopItem
There was a problem hiding this comment.
installDesktopItem doesn't seem to exist. Based on what I saw in other derivations, I used copyDesktopItems. Is it what you meant?
drupol
force-pushed
the
init/jetbrains-toolbox-init
branch
from
221af4d
to
60b6d9f
Compare
drupol
force-pushed
the
init/jetbrains-toolbox-init
branch
6 times, most recently
from
f464efe
to
e345aa6
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/help-with-a-derivation-package/8686/14 |
drupol
force-pushed
the
init/jetbrains-toolbox-init
branch
from
e345aa6
to
db70bd5
Compare
drupol
force-pushed
the
init/jetbrains-toolbox-init
branch
from
db70bd5
to
26bd3c7
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Thanks! |
Derivation for Jetbrains Toolbox.
This PR
doCheck=false;If you want to test this thing quickly:
NIXPKGS_ALLOW_UNFREE=1 nix run "github:drupol/nixpkgs/init/jetbrains-toolbox-init#jetbrains-toolbox" --impureThis PR has been created due to the lack of feedback from the original author in #206288
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)