Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats: 1.8.2 -> 1.9.0 #220630

Merged
merged 3 commits into from
Mar 14, 2023
Merged

bats: 1.8.2 -> 1.9.0 #220630

merged 3 commits into from
Mar 14, 2023

Conversation

tricktron
Copy link
Member

@tricktron tricktron commented Mar 11, 2023

Description of changes
How to Test Locally

nix-build -A bats.tests and nix-build -A resholve.tests.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • [] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@abathur abathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally with nix-build -A bats.tests and nix-build -A resholve.tests.

Thanks for picking this up. I noticed the release, but decided to wait for r-ryantm to open an update and then forgot to go check on why it hadn't come through.

For posterity, change notes: https://github.com/bats-core/bats-core/releases/tag/v1.9.0

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/863

@SuperSandro2000 SuperSandro2000 merged commit a60b758 into NixOS:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants