opencv: misc CUDA-related updates and fixes; add enableLto #221370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use cudaPackages instead of cudatoolkit (reduces download/closure size) - set C/C++ compiler when building with CUDA to ensure NVCC has an appropriate backing compiler - add flag to build with CUDNN (disabled by default due to increase in closure size) - add flag to build with LTO (enabled by default)
|
Running And the failures (all of which seem unrelated): Failed derivations
|
samuela
approved these changes
Mar 16, 2023
12 tasks
|
Hi all, Are there any blockers preventing this from being merged? |
|
LGTM, @basvandijk @SomeoneSerge thoughts? |
| # Only clang supports thin LTO, so we must either be using clang through the stdenv, | ||
| stdenv.cc.isClang || | ||
| # or through the backend stdenv. | ||
| (enableCuda && backendStdenv.cc.isClang) |
There was a problem hiding this comment.
I guess we currently can't test this as we hard-wire cuda to gcc. H'm
SomeoneSerge
approved these changes
Mar 28, 2023
|
In the interest of keeping PRs moving along, I went ahead and merged! Thanks so much @ConnorBaker ! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-46/26872/1 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a re-land of #218044, but against
staginginstead ofmaster.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)