gbsplay: init at version 2016-12-17 #22146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globin
requested changes
Jan 25, 2017
|
|
||
| # preConfigure = '' | ||
| # sed -i "s:check_include pulse/simple.h:check_include pulse/simple.h ${libpulseaudio}/include:" ./configure; | ||
| # ''; |
There was a problem hiding this comment.
Please remove the commented lines.
| # sed -i "s:check_include pulse/simple.h:check_include pulse/simple.h ${libpulseaudio}/include:" ./configure; | ||
| # ''; | ||
|
|
||
| configureFlagsArray = [ |
There was a problem hiding this comment.
Indentation is off for the rest of the file starting here.
| meta = with stdenv.lib; { | ||
| description = "gameboy sound player"; | ||
| license = licenses.gpl1; | ||
| maintainers = with maintainers; [ dasuxullebt ]; |
globin
reviewed
Jan 26, 2017
|
|
||
| meta = with stdenv.lib; { | ||
| description = "gameboy sound player"; | ||
| license = licenses.gpl1; | ||
| platforms = ["i686-linux" "x86_64-linux"]; |
There was a problem hiding this comment.
platforms = platforms.linux/unix; should generally fit better.
There was a problem hiding this comment.
I have no way to tell whether it works on platforms other than x86 and x86_64. This code seems to do some lowlevel stuff, so it might not be portable.
globin
approved these changes
Jan 26, 2017
|
bump will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to add a gbsplay package
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)