Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart: add update script #221694

Merged
merged 1 commit into from Mar 21, 2023
Merged

dart: add update script #221694

merged 1 commit into from Mar 21, 2023

Conversation

gilice
Copy link
Member

@gilice gilice commented Mar 17, 2023

Description of changes

Adds an updater-script for dart. Update-source-version won't cut it because it cannot handle multi-source.

Things done
  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 23.05 Release Notes (or backporting 22.11 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gilice
Copy link
Member Author

gilice commented Mar 17, 2023

Extra-good because r-ryantm should pick it up right after the merge, since t here's 2.19.4 now

@wegank
Copy link
Member

wegank commented Mar 17, 2023

I'm afraid this won't work, the update script should also update the hashes (via update-source-version)...

@wegank wegank marked this pull request as draft March 17, 2023 19:27
@gilice
Copy link
Member Author

gilice commented Mar 17, 2023

Oh that is very true. Kinda forgot that ...... Doing now.

@gilice
Copy link
Member Author

gilice commented Mar 18, 2023

@wegank I tried a different approach.
Ready for re-review

@wegank wegank merged commit d5a71a4 into NixOS:master Mar 21, 2023
21 checks passed
@gilice gilice mentioned this pull request Mar 21, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants