rofi-blezz: init at unstable-2022-09-07

[JohnJohnstone]

Description of changes

Adds rofi-blezz

Things done

Tested on sway and i3

• Built on platform(s)
  • [ X] x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• [X ] Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• [ X] Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• [ X] Fits CONTRIBUTING.md.

[ocfox]

Also squash commit, add maintainer and package init.

[programmerHaaks]

What's missing for this to get merged? Just the squash?

[isabelroses]

The title should be changed to rofi-blezz: init at unstable-2022-09-07. The all the commits except the commit titled maintainers: add johnjohnstone should also be squashed into a commit titled rofi-blezz: init at unstable-2022-09-07. The package should also be moved into the by-name standard, https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md.

[JohnJohnstone]

Not sure how to squash my commits, I have done it before but likely due to error on my part I have other people commits in between my own and since this is a few years old I cant even find my commit in the tool i use for git. I could just make a new pull request? Any help would be much appreciated

[isabelroses]

Not sure how to squash my commits, I have done it before but likely due to error on my part I have other people commits in between my own and since this is a few years old I cant even find my commit in the tool i use for git. I could just make a new pull request? Any help would be much appreciated

To squash your commits you can type git rebase -i 2903f85, this will open up your editor with a collection of your last serval commits. Leave the commit titled rofi-blezz: Init at unstable-2022-09-07 as pick rofi-blezz: Init at unstable-2022-09-07 whilst changing the other commits to say s commit-name. Then you will have to force push to this branch git push -f.

[JohnJohnstone]

Not sure how to squash my commits, I have done it before but likely due to error on my part I have other people commits in between my own and since this is a few years old I cant even find my commit in the tool i use for git. I could just make a new pull request? Any help would be much appreciated

To squash your commits you can type git rebase -i 2903f85, this will open up your editor with a collection of your last serval commits. Leave the commit titled rofi-blezz: Init at unstable-2022-09-07 as pick rofi-blezz: Init at unstable-2022-09-07 whilst changing the other commits to say s commit-name. Then you will have to force push to this branch git push -f.

Thank You, Commit History should be fixed now.

[Aleksanaa]

wrappers are wrapping executables not libraries, so what does wrapGAppsHook3 do here?

[JohnJohnstone]

Yeah it is not required. Based my package on rofi-top that uses it. I have removed the wrapper and rofi-blezz works as expected.