Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.debugpy: fix test failures #221772

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Mar 18, 2023

Description of changes

Fixes #221359 by patching one failing test and disabling the other. In the output I saw something about it wanting to use /dev/tty, but I don't understand the tests well enough to say that's the reason.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 221772 run on x86_64-linux 1

1 package failed to build:
  • python311Packages.debugpy
3 packages built:
  • home-assistant-component-tests.debugpy
  • python310Packages.debugpy
  • vscode-extensions.ms-python.python

@austinbutler
Copy link
Member Author

Guess it still fails on Python 3.11. But at least it fixes the VS Code Python extension.

@kira-bruneau
Copy link
Contributor

Result of nixpkgs-review pr 221772 run on x86_64-linux 1

1 package failed to build:
  • python311Packages.debugpy
3 packages built:
  • home-assistant-component-tests.debugpy
  • python310Packages.debugpy
  • vscode-extensions.ms-python.python

Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry! Forgot to get back to this - thanks for the fix!!

@kira-bruneau kira-bruneau merged commit 371cc3a into NixOS:master Mar 18, 2023
@austinbutler austinbutler deleted the fix-debugpy-test-fails branch March 19, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python3.pkgs.debugpy
2 participants