Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyrr: 0.10.3 -> unstable-2022-07-22 #221879

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

ckiee
Copy link
Member

@ckiee ckiee commented Mar 18, 2023

Description of changes

It stopped building on python39Packages.pyrr, which is needed for pkgs.friture to work, due to some other old dependencies. There are no new releases on PyPI.

Tested build of friture, python39Packages.pyrr and python3Packages.pyrr on x86_64-linux: all three previously failed builds work.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • (friture) Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyaeanyx
Copy link
Member

Package maintainer for friture here, I tested this fix and everything works fine again. Would be really cool if we could get this merged.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/875

@ckiee
Copy link
Member Author

ckiee commented Mar 24, 2023

Thank you for maintaining friture, I use it like, at least once a week, very fun. :3

@alyaeanyx
Copy link
Member

Kinda feel obligated to clarify that I just maintain the NixOS package for friture, I'm only an occasional contributer to upstream 😅

It stopped building on python39Packages.pyrr, which is needed for
pkgs.friture to work, due to some other old dependencies. There are no
new releases on PyPI.

Tested build of friture, python39Packages.pyrr and python3Packages.pyrr
on x86_64-linux: all three previously failed builds work.
@ckiee
Copy link
Member Author

ckiee commented Mar 24, 2023

Result of nixpkgs-review pr 221879 run on x86_64-linux 1

1 package failed to build:
  • manim
5 packages built:
  • friture
  • python310Packages.moderngl-window
  • python310Packages.pyrr
  • python311Packages.moderngl-window
  • python311Packages.pyrr

@ckiee
Copy link
Member Author

ckiee commented Mar 24, 2023

Friture seems to explode on runtime on 9af5c71 (very recent master) now:

Unhandled exception: Traceback (most recent call last):
  File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/__init__.py", line 23, in 
    from . import multiarray
  File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/multiarray.py", line 10, in 
    from . import overrides
  File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/overrides.py", line 6, in 
    from numpy.core._multiarray_umath import (
ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/nix/store/xpw3in80j6x3v20a7ilfrs6srfx5qjfi-friture-0.49/bin/.friture-wrapped", line 9, in
from friture.analyzer import main
File "/nix/store/xpw3in80j6x3v20a7ilfrs6srfx5qjfi-friture-0.49/lib/python3.9/site-packages/friture/analyzer.py", line 39, in
from friture.about import About_Dialog # About dialog
File "/nix/store/xpw3in80j6x3v20a7ilfrs6srfx5qjfi-friture-0.49/lib/python3.9/site-packages/friture/about.py", line 23, in
import numpy
File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/init.py", line 141, in
from . import core
File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/init.py", line 49, in
raise ImportError(msg)
ImportError:

IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!

Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.

We have compiled some common reasons and troubleshooting tips at:

https://numpy.org/devdocs/user/troubleshooting-importerror.html

Please note and check the following:

  • The Python version is: Python3.9 from "/nix/store/93x6crjd9rcdi12cqv1am8mym3iyq424-python3-3.9.16/bin/python3.9"
  • The NumPy version is: "1.24.2"

and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.

Original error was: No module named 'numpy.core._multiarray_umath'

The stack trace doesn't indicate this is related to pyrr though, and manually rebasing and running directly from the store ./result link from nix-build seems to avoid this failure. I think it's okay.

@alyaeanyx
Copy link
Member

alyaeanyx commented Mar 24, 2023

Oof, another issue. I'll try to bisect it. EDIT: Couldn't reproduce, seems to be fine

@SuperSandro2000 SuperSandro2000 changed the title pythonPackages.pyrr: 0.10.3 -> 2022-07-22 pythonPackages.pyrr: 0.10.3 -> unstable-2022-07-22 Mar 27, 2023
@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.pyrr

@SuperSandro2000 SuperSandro2000 merged commit af79cc0 into NixOS:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants