-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pyrr: 0.10.3 -> unstable-2022-07-22 #221879
Conversation
Package maintainer for friture here, I tested this fix and everything works fine again. Would be really cool if we could get this merged. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Thank you for maintaining friture, I use it like, at least once a week, very fun. :3 |
Kinda feel obligated to clarify that I just maintain the NixOS package for friture, I'm only an occasional contributer to upstream 😅 |
It stopped building on python39Packages.pyrr, which is needed for pkgs.friture to work, due to some other old dependencies. There are no new releases on PyPI. Tested build of friture, python39Packages.pyrr and python3Packages.pyrr on x86_64-linux: all three previously failed builds work.
a122fa5
to
cb619a0
Compare
Result of 1 package failed to build:
5 packages built:
|
Friture seems to explode on runtime on 9af5c71 (very recent master) now: Unhandled exception: Traceback (most recent call last): File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/__init__.py", line 23, in from . import multiarray File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/multiarray.py", line 10, in from . import overrides File "/nix/store/hwrvr28a6h6b22sghfd27hns45yk015y-python3.11-numpy-1.24.2/lib/python3.11/site-packages/numpy/core/overrides.py", line 6, in from numpy.core._multiarray_umath import ( ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'
and make sure that they are the versions you expect. Original error was: No module named 'numpy.core._multiarray_umath' The stack trace doesn't indicate this is related to pyrr though, and manually rebasing and running directly from the store |
Oof, another issue. I'll try to bisect it. EDIT: Couldn't reproduce, seems to be fine |
@ofborg build python310Packages.pyrr |
Description of changes
It stopped building on python39Packages.pyrr, which is needed for pkgs.friture to work, due to some other old dependencies. There are no new releases on PyPI.
Tested build of friture, python39Packages.pyrr and python3Packages.pyrr on x86_64-linux: all three previously failed builds work.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)