Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.torchvision: switch to backendStdenv.cc from cudatoolkit.cc #221950

Merged
merged 1 commit into from Mar 20, 2023
Merged

python3Packages.torchvision: switch to backendStdenv.cc from cudatoolkit.cc #221950

merged 1 commit into from Mar 20, 2023

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Mar 19, 2023 •
edited

Description of changes

Closes #221898.

Removes unused cudaFlags attribute.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ConnorBaker
Copy link
Contributor Author

Result of nixpkgs-review pr 221950 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; cudaForwardCompat = false; cudaCapabilities = [ "8.6" ]; }' run on x86_64-linux 1

@ConnorBaker ConnorBaker self-assigned this Mar 19, 2023
@ConnorBaker ConnorBaker marked this pull request as ready for review March 19, 2023 03:21
@ConnorBaker
Copy link
Contributor Author

CC @NixOS/cuda-maintainers

@samuela samuela merged commit 862746a into NixOS:master Mar 20, 2023
9 checks passed
@ConnorBaker ConnorBaker deleted the fix/221898-torchvision-backendStdenv branch March 20, 2023 23:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-46/26872/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuela samuela samuela approved these changes

@SomeoneSerge SomeoneSerge SomeoneSerge approved these changes

Assignees

@ConnorBaker ConnorBaker

Labels
6.topic: cuda 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
CUDA Team
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pythonPackages.torchvision: switch to backendStdenv.cc from cudatoolkit.cc
4 participants
@ConnorBaker @nixos-discourse @samuela @SomeoneSerge