Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: from 0.15.9 to 0.16.2 #22224

Merged
merged 1 commit into from
Jan 29, 2017
Merged

fzf: from 0.15.9 to 0.16.2 #22224

merged 1 commit into from
Jan 29, 2017

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jan 28, 2017

Motivation for this change

fzf has been updated

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

LnL7
LnL7 approved these changes Jan 28, 2017
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current version is 0.15.9

@nhooyr nhooyr changed the title fzf: from 0.15.1 to 0.16.2 fzf: from 0.15.9 to 0.16.2 Jan 28, 2017
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 28, 2017

Fixed.

@kevincox
Copy link
Contributor

Appears to break the build on darwin.

@LnL7
Copy link
Member

LnL7 commented Jan 29, 2017

My darwin build also failed, I don't understand why it can't find install_name_tool.

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 29, 2017

Ok, I removed that part, lets see what happens.

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 29, 2017 •
edited

It works fine now. I guess there is no

cycle between $out and $bin

anymore.

@LnL7 LnL7 merged commit 5e7221e into NixOS:master Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhooyr @kevincox @LnL7