Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nim: fix darwin build #222285

Closed
wants to merge 1 commit into from
Closed

nim: fix darwin build #222285

wants to merge 1 commit into from

Conversation

viraptor
Copy link
Contributor

Description of changes

Add the required framework to fix the nim build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@viraptor
nim: fix darwin build
15e20ed 
Add the required framework to fix the nim build.
@viraptor viraptor requested a review from ehmry as a code owner March 21, 2023 03:10
@github-actions github-actions bot added the 6.topic: nim Nim programing language label Mar 21, 2023
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 labels Mar 21, 2023
@wegank
Copy link
Member

wegank commented Mar 21, 2023

#222243

@vcunat vcunat marked this pull request as draft March 26, 2023 08:25
@wegank wegank mentioned this pull request Mar 27, 2023
Merged
12 tasks
@domenkozar domenkozar mentioned this pull request Mar 27, 2023
Closed
@domenkozar
Copy link
Member

Merged the other one as it was not in draft. Still need to fix packages that use Security, but the rest of them can build now.

@domenkozar domenkozar closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry ehmry is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: nim Nim programing language 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viraptor @wegank @domenkozar