libtiff: propagate libdeflate and format expression (resumed) #222518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libdeflate is a dependency of libtiff which pkg-config expects seeing, and openjpeg doesn't use libdeflate directly (aside from libtiff) [1] As it is now added to the propagatedBuildInputs of the Remove from the buildInputs of reverse-dependent packages. 1: https://packages.debian.org/source/buster/openjpeg2
|
|
trofi
approved these changes
Apr 8, 2023
|
This seems like some weird mess. The direct dependency is only needed for static linking ( |
|
Though yes, the same applies to the other three libraries as well... anyway, the propagation shouldn't be expensive here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Move
libdeflateintopropagatedBuildInputsafter #216181Remove
libdeflatefrom thebuildInputsofopenjpeg, since the latter only directly depends onlibtiffbut notlibdeflate.Fixes #221918 (
entanglebuild failure)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)