-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etlegacy: init at 2.81.1 #222633
etlegacy: init at 2.81.1 #222633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on x86_64-linux
.
Thank you for packaging this 🥳
worked for me as well. |
The assets are on a different licence Creative Commons BY-NC-SA 3.0 |
Ah, good catch. I looked up the license in
|
4919d88
to
576c09d
Compare
See packaging request: etlegacy - fixes NixOS#101187. This change has been updated in light of feedback from @teto to use a more conventional structure consisting of a single stdenv.mkDerivation, with the wrapper moved into postInstall. fetchGit was substituted for fetchFromGitHub. The 'fakeGit' script was greatly simplified to simply echo ${version}. meta.mainProgram was also added, as the filename of the main binary varies according to the architecture, and is referenced in the XDG .desktop files. This also avoids collisons as it's not overly uncommon for people to have both 32- and 64-bit versions of this game installed at the same time. meta.license was updated to include the cc-by-nc-sa-30 license, which some resources use. Finally the configuration was passed through the alejandra nix formatter.
@ashleyghooper I propose we merge this, darwin support can come later. This way it will make it to the nixos 23.05 release. |
Yes, agreed! |
Big thanks to @teto for all his guidance with getting the derivation into a better state. |
Hello, I'm unable to run this on my machine, I get the following error log:
I can easily reproduce the error by doing:
Do you have a clue? |
The issue has been identified and the PR to fix this is at #250249 Reviews welcome! |
Description of changes
First nixpkgs package for this game. Built for both
i686-linux
andx86_64-linux
.sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)First package for ET: Legacy, for the current release version of the game. I have played both the 32-bit and 64-bit versions of the game on online servers.