feed2imap-go: init at 1.6.0 #222690
Merged
feed2imap-go: init at 1.6.0 #222690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2086 |
Comment on lines
17
to
19
| # Move the print-cache tool out of the PATH, seems to be an internal development tool | ||
| mkdir $out/libexec | ||
| mv $out/bin/print-cache $out/libexec |
There was a problem hiding this comment.
Is this even used or does it work in this location without extra patches? if not we can just delete it
There was a problem hiding this comment.
Good question. I assumed it was a debugging tool; not worth having in the PATH, but good to have around. I’m asking upstream at Necoro/feed2imap-go#94
There was a problem hiding this comment.
Resolved, the binary should be deleted. Updated and squashed this branch.
pkgs/applications/networking/feedreaders/feed2imap-go/default.nix
Outdated
Show resolved
Hide resolved
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)