-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python*Packages.pytest: defaults to pytest_30 #22280
Conversation
@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @garbas, @spwhitt and @FRidh to be potential reviewers. |
@@ -3,7 +3,7 @@ | |||
pythonPackages.buildPythonApplication rec { | |||
name = "mir.qualia-${version}"; | |||
version = "1.0.0"; | |||
doCheck = false; # 1.0.0-released pytests are broken | |||
doCheck = false; # 1.0.0-released pytests_29 are broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a mistake changing the comment instead of the dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for spotting it! It is fixed and pushed again.
1bd2a24
to
6494bf1
Compare
@lsix, if you want to test this, then I recommend just switching to python 3.0, and push to |
Or, since PR's are now build, you could check https://prs.nix.gsc.io/project/nixos |
@FRidh PRs are build by hydra? |
@matthiasbeyer yes, and this is quite new and have been brought to us by @grahamc (A big thanks to him for that). You can see the mail about that on nix-dev here: http://lists.science.uu.nl/pipermail/nix-dev/2017-January/022621.html. @FRidh since I can rely on hydra to check what migrating to pytest-3 breaks, I’ll do that. I mark this PR as WIP and get to work ! |
@lsix actually, I just realized that not all Python packages are build by the jobset that instance uses. So, for testing all Python packages I recommend you still use the |
is this because I use the nixpkgs expression, not the nixos one? I'd be happy to change this. |
6494bf1
to
4cf8ae3
Compare
@FRidh according to https://headcounter.org/hydra/eval/347928?compare=-86400 I should be good with this version of the PR. |
great, thank you! |
This commit is a no-op. All derivations that depended on
pytest_29
aspytest
now depend on it explicitely.The next step will be to check which derivation can use
pytest_30
instead ofpytest_29
, but this can be done when updating the derivations.cc @FRidh
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)