asterisk: add lts version #22358
Merged
asterisk: add lts version #22358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yorickvP, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DerTim1, @auntieNeo and @fpletz to be potential reviewers. |
|
I can check this out in a few hours... |
DerTim1
suggested changes
Feb 2, 2017
pkgs/servers/asterisk/default.nix
Outdated
| lts = ./lts.nix; | ||
| }; | ||
| in | ||
| { stdenv, pkgs, |
There was a problem hiding this comment.
I think this is unusual style. The only differences between the two versions (lts & stable) are version and hash. So it would be smarter to switch inside one nix-file, compare for example PostgreSQL https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/sql/postgresql/default.nix
There was a problem hiding this comment.
okay, I changed it to be inside one nix-file like postgresql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Asterisk has a few different versions available. Some of them might be more suitable for server use than others. I added a way to specify which asterisk version to use, and also a way to fetch external dependencies (it was doing it at build time, leading to hydra failures).
I'm not sure if what I'm doing is the correct way.
I also added myself as a maintainer to this package.
(cc: @grahamc, @DerTim1, @fpletz )
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)