Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64-support for NVIDIA closed and open source drivers #225741

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

mikatammi
Copy link
Contributor

@mikatammi mikatammi commented Apr 11, 2023

Description of changes

NVIDIA seems to have provided closed source (and the new open source) aarch64-linux drivers for some time, alongside the x86_64 package. Adding it

Things done

I used NVIDIA Jetson AGX Orin developer kit as a test platform. It had (already quite outdated) NVIDIA Quadro P1000 GPU connected to the PCI Express slot. Tested X11 with i3, and Wayland with Weston. Basic 3D acceleration at least seems to be working

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@PedroHLC
Copy link
Member

@Kiskae an interesting one here.

Copy link
Contributor

@Kiskae Kiskae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems to be good, just some minor nitpicks and things to clarify regarding packages with binary sources that differ based on architecture

pkgs/os-specific/linux/nvidia-x11/generic.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/nvidia-x11/generic.nix Show resolved Hide resolved
pkgs/os-specific/linux/nvidia-x11/open.nix Outdated Show resolved Hide resolved
@mikatammi
Copy link
Contributor Author

Tried to rebase and force-push to get rid of the "The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked" failure, but looks like it hasn't be caused by this PR to begin with

@Artturin
Copy link
Member

Rebase again, fe2ecaf fixed the eval issue

@mikatammi
Copy link
Contributor Author

After rebase checks seems to be okay

@ofborg ofborg bot requested a review from NickCao April 13, 2023 19:48
@mikatammi mikatammi force-pushed the nvidia_x11_aarch64 branch 2 times, most recently from e913a9c to 3e5b2e6 Compare April 14, 2023 14:03
* Add aarch64-linux binary packages
* add cross-compilation support to open-package

Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
@mikatammi
Copy link
Contributor Author

Solved the merge conflict and now going again

@ofborg ofborg bot requested a review from Kiskae April 14, 2023 14:53
@NickCao NickCao merged commit 985d5e6 into NixOS:master Apr 16, 2023
@mikatammi mikatammi deleted the nvidia_x11_aarch64 branch April 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants