master_me: init at 1.2.0 #226373
master_me: init at 1.2.0 #226373
Conversation
|
There seems to be a failing test https://github.com/NixOS/nixpkgs/pull/226373/checks?check_run_id=12776391277 caused by a too old macos version https://developer.apple.com/documentation/appkit/nspasteboardtypeowner |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2276 |
|
Result of 1 package built:
|
|
Can't really help with the macos part don't own a mac. Binary works fine under wayland/sway. |
| patchShebangs ./dpf/utils/ | ||
| substituteInPlace ./dpf/utils/res2c.py \ | ||
| --replace '/usr/bin/env python3' ${python3.interpreter} |
There was a problem hiding this comment.
patchShebangs is not working if it can't find python in any of the inputs
There was a problem hiding this comment.
this is indeed a shebang https://github.com/DISTRHO/DPF/blob/d9088872a3ee65d33c6b9a60222dc9364b22b81a/utils/res2c.py
There was a problem hiding this comment.
this is still open and not good practise
|
Thanks for the feedback, all done! |
Did you do a wrong force push by accident? It seems like you reverted somet things again. |
I found only one force push on this page, from 2023-05-31. I'm not sure where I can find the commit that has broken = stdenv.isDarwin; # error: no type or protocol named 'NSPasteboardType'Does it contain any other changes I should re-apply? |
There was a problem hiding this comment.
Looks good to me! I've been using this package for the last month and it has been working well. The changes to buildInputs suggested by @SuperSandro2000 seem like they would be good to add, but everything works the way it is now.
| patchShebangs ./dpf/utils/ | ||
| substituteInPlace ./dpf/utils/res2c.py \ | ||
| --replace '/usr/bin/env python3' ${python3.interpreter} |
There was a problem hiding this comment.
this is still open and not good practise
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Result of 1 package built:
|
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)