-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nixos test for radicale #22683
Add nixos test for radicale #22683
Conversation
@aneeshusa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
cryptography is updated so likely this is a mass rebuild |
|
e43e88a
to
b0135b4
Compare
pkgs/servers/radicale/default.nix
Outdated
pythonPackages.flup | ||
pythonPackages.ldap | ||
pythonPackages.sqlalchemy | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably should keep them for python2 in order not to break existing configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
pkgs/top-level/python-packages.nix
Outdated
@@ -8622,7 +8622,7 @@ in { | |||
sha256 = "1z27wdxs5rj5xhhqfzvzn3yg682irkxw6dcs5jj7mcf97psk8gd8"; | |||
}; | |||
|
|||
buildInputs = with self; [ nose pybcrypt]; | |||
propagatedBuildInputs = with self; [ nose bcrypt ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you moved it from buildInputs
to propagatedBuildInputs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @aneeshusa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, bcrypt
needs to be propagated for modules that depend on passlib
to be able to use the bcrypt
backend. I added this to the commit message.
b0135b4
to
6d7920b
Compare
Thanks for taking a look, I've addressed review comments and re-tested this. I also added a commit adding myself as a maintainer. |
6d7920b
to
f71a666
Compare
Also propagated bcrypt so that downstream dependencies are able to use the bcrypt backend.
Includes testing bcrypt authentication.
None of these dependencies is required for radicale to function, and flup in particular prevents usage with Python 3.
f71a666
to
8f4d778
Compare
I've rebased this on master. I'd like to have this merged before Radicale 2.0 comes out of beta if someone wants to take a look! |
Motivation for this change
I attempted to run radicale on Python 3 and ran into some errors along the way. This PR has a few changes in separated commits:
cc radicale maintainers @pSub @edwtjo
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)