darwin.darling: rename to darwin.darling-sandbox to avoid confusion with darling #228113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Absolutely! |
ofborg
bot
added
6.topic: darwin
wegank
approved these changes
Apr 25, 2023
|
Let me add a line in the release note and reword the commit to make it ready. |
ShamrockLee
force-pushed
the
darling-sandbox
branch
from
af00749
to
e410b52
Compare
Distinguish this package from Darling, the emulation layer to run Darwin apps on Linux
ShamrockLee
force-pushed
the
darling-sandbox
branch
from
e410b52
to
becb795
Compare
|
cc @NixOS/darwin-maintainers |
Closed
|
I've found something mysterious on my machine: removing that line from So is the package only served as headers (so that |
|
I don't have any experience developing software on Darwin, nor do I have a usable Darwin setup. All my knowledge about Darwin comes form Nixpkgs. The package is introduced by @matthewbauer. Maybe we could ask him. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR renames
darwing.darlingtodarwing.darling-sandbox, since it only packages "the sandbox part" of Darling and is meant to be executed directly on Darwin instead of on Linux.See also #227765 for the progress of
darlingpackaging.Things done
pkgs.darwinevaluates successfully)sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage (done on Linux, which is actually not that helpful.)./result/bin/)